Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom streams and paths #118

Merged
merged 18 commits into from Mar 12, 2014
Merged

Conversation

lisachenko
Copy link
Member

This PR introduces support for different stream wrappers, such as http://, phar://, compress.zlib://, etc. This PR is experimental now because realpath() and stream_resolve_include_path() functions were replaced with custom resolver, need to add test cases before merging into master to verify, that everything is ok.

After merging of this PR it will be possible to use goaop for standalone console applications and tools that can be very interesting.

@lisachenko
Copy link
Member Author

PR for #117

* Normalizes options for the kernel
* @param $options
*
* @return array|mixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not always an array? why mixed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly phpStorm add this for me :) This should be only "array"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe adjust it and plug your friendly theme as well http://github.com/cordoval/symfony2Colors

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@lisachenko
Copy link
Member Author

@cordoval you can try to play with https://github.com/lisachenko/gush/commit/64ad7d80eaf7b20f56097cb24233ae8c07b15530. It's initial configuration that simple prevent execution of gush itself :)

…ith relative including and include_path checking
Conflicts:
	src/Go/Core/GoAspectContainer.php
	src/Go/Instrument/ClassLoading/SourceTransformingLoader.php
	src/Go/Instrument/Transformer/WeavingTransformer.php
lisachenko added a commit that referenced this pull request Mar 12, 2014
Add support for custom streams and paths
@lisachenko lisachenko merged commit 2ed1ec1 into master Mar 12, 2014
@matthiasnoback
Copy link

@lisachenko Interesting work!

@lisachenko
Copy link
Member Author

@matthiasnoback yes, it was very interesting to solve this outstanding task :) There was a lot of magic and it took all my knowledge about streams to implement this properly. Hope, that I didn't make an error somewhere...

Thank you for your interest to my work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants