New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom streams and paths #118
Conversation
…nce of explicit protocols in the filename
…o have an ability to speed up application in the future by removing extra checks
…h() to have a support for different stream wrappers, e.g. phar, compress.zlib, etc
…ses for framework
…hecking of prebuiltCache flag
…iltCache param in the FilterInjectorTransformer
PR for #117 |
* Normalizes options for the kernel | ||
* @param $options | ||
* | ||
* @return array|mixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this not always an array? why mixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Friendly phpStorm add this for me :) This should be only "array"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe adjust it and plug your friendly theme as well http://github.com/cordoval/symfony2Colors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)
… code to have an ability to move source code into another path without changes, unix-style slashes instead of DIRECTORY_SEPARATOR
@cordoval you can try to play with https://github.com/lisachenko/gush/commit/64ad7d80eaf7b20f56097cb24233ae8c07b15530. It's initial configuration that simple prevent execution of gush itself :) |
…ith relative including and include_path checking
Conflicts: src/Go/Core/GoAspectContainer.php src/Go/Instrument/ClassLoading/SourceTransformingLoader.php src/Go/Instrument/Transformer/WeavingTransformer.php
Add support for custom streams and paths
@lisachenko Interesting work! |
@matthiasnoback yes, it was very interesting to solve this outstanding task :) There was a lot of magic and it took all my knowledge about streams to implement this properly. Hope, that I didn't make an error somewhere... Thank you for your interest to my work :) |
This PR introduces support for different stream wrappers, such as http://, phar://, compress.zlib://, etc. This PR is experimental now because
realpath()
andstream_resolve_include_path()
functions were replaced with custom resolver, need to add test cases before merging into master to verify, that everything is ok.After merging of this PR it will be possible to use goaop for standalone console applications and tools that can be very interesting.